Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact and replace StreamIs{,Not}Empty Refaster rules #1028

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Compact and replace StreamIs{,Not}Empty Refaster rules #1028

merged 2 commits into from
Mar 22, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Feb 11, 2024 •
edited
Loading

❗ This PR is on top of #1025. ❗

Suggested commit message:

Compact and replace `StreamIs{,Not}Empty` Refaster rules (#1028)

The new `StreamFindAnyIs{Empty,Present}` rules are simpler thanks to the
use of `@AlsoNegation`. In some cases an additional application of the
`OptionalIsEmpty` rule will be required.

@Stephan202 Stephan202 added this to the 0.15.0 milestone Feb 11, 2024
@Stephan202 Stephan202 mentioned this pull request Feb 11, 2024
Merged
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie modified the milestones: 0.15.0, 0.16.0 Feb 11, 2024
Base automatically changed from giovannizotta/collecting-and-then-is-empty to master February 11, 2024 11:01
@Stephan202 Stephan202 force-pushed the sschroevers/empty-stream-simplifications branch from 989d4c5 to fa742d1 Compare February 11, 2024 15:09
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/empty-stream-simplifications branch from fa742d1 to 4cbc5a0 Compare February 11, 2024 17:04
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

giovannizotta
giovannizotta approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@giovannizotta giovannizotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice consolidation, thanks!

@rickie rickie modified the milestones: 0.16.0, 0.17.0 Mar 8, 2024
@Stephan202 Stephan202 force-pushed the sschroevers/empty-stream-simplifications branch from 4cbc5a0 to 4b76a71 Compare March 17, 2024 10:00
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 @rickie
Compact and replace StreamIs{,Not}Empty Refaster rules
09610c3 
The new `StreamFindAnyIs{Empty,Present}` rules are simpler thanks to the
use of `@AlsoNegation`. In some cases an additional application of the
`OptionalIsEmpty` rule will be required.
@Stephan202 @rickie
Post-rebase fix
311e7b0
@rickie rickie force-pushed the sschroevers/empty-stream-simplifications branch from 178792b to 311e7b0 Compare March 22, 2024 07:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie merged commit f8cac19 into master Mar 22, 2024
15 checks passed
@rickie rickie deleted the sschroevers/empty-stream-simplifications branch March 22, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannizotta giovannizotta giovannizotta approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @giovannizotta